feat: migrate remaining sync decrypt/encrypt calls#8923
Open
bdesoky wants to merge 1 commit into
Open
Conversation
de0b432 to
1c11e37
Compare
1c11e37 to
e106dc2
Compare
e106dc2 to
a52f1ae
Compare
vinhkhangtieu
approved these changes
Jun 3, 2026
vinhkhangtieu
left a comment
There was a problem hiding this comment.
migrate decrypt/encrypt call to async
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WCN-284
This pull request introduces a comprehensive migration from synchronous encryption and decryption methods to their asynchronous counterparts throughout the codebase, with a focus on improving support for v2 encryption. The changes affect key management, wallet operations, transaction verification, and API routes, ensuring better scalability and compatibility with modern cryptographic practices. Additionally, new async verification utilities are introduced, and related tests and error messages are updated accordingly.
Migration to Async Encryption/Decryption:
encryptanddecryptwithencryptAsyncanddecryptAsyncin wallet logic (lightning.ts,selfCustodialLightning.ts), UTXO coin and transaction verification, and Express API handlers to support v2 encryption and improve non-blocking behavior. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Async Key Verification Utilities:
verifyUserPublicKeyAsynctoverifyKey.tsand updated transaction and coin verification logic to use the new async method, while preserving the synchronous version for backward compatibility. [1] [2] [3] [4] [5] [6] [7]Refactoring and API Consistency:
Test and Error Message Updates:
Backward Compatibility and Deprecation:
These changes collectively modernize the cryptographic operations in the codebase, preparing it for future enhancements and improved security practices.